androidsdk: Re-add emulator by clefru · Pull Request #49515 · NixOS/nixpkgs

clefru · 2018-10-31T12:17:22Z

Motivation for this change

<clefru> I can't execute <nixpkgs-unstable>.androidenv.android_8_0/libexec/tools/emulator. This will give "./emulator: line 5: /nix/store/[...]-android-sdk-26.1.1/libexec/tools/.emulator-wrapped: No such file or directory". The file is clearly there however. This smells like a linker error. "ldd -d"-ing the file shows no missing dependencies. "objdump -x" shows no crazy rpath's. Running that wrapped file with LD_DEBUG=all doesn't even produce a single line of 
<clefru> output. strace-ing shows the execve call fails right there. I am bit puzzled. 
<clever> clefru: what about file on the binary?
<clefru> file-ing "/nix/store/[...]-android-sdk-26.1.1/libexec/tools/.emulator-wrapped" gives  ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.15, stripped, so I don't even have an arch mismatch
<clever> clefru: yep, its /lib64/ld-linux-x86-64.so.2 thats not found

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Mic92 · 2018-10-31T23:46:38Z

pkgs/development/mobile/androidenv/androidsdk.nix

Was is not possible to set the rpath and interpreter within the same invocation?

This also seems to duplicated LD_LIBRARY_PATH below. Is emulator calling any unpatched binaries or is using dlopen at runtime that justify LD_LIBRARY_PATH? Otherwise all libraries could be moved up to this rpath invocation.

This also seems to duplicated LD_LIBRARY_PATH below. Is emulator calling any unpatched binaries or is using dlopen at runtime that justify LD_LIBRARY_PATH? Otherwise all libraries could be moved up to this rpath invocation.

I can't answer that.

Was is not possible to set the rpath and interpreter within the same invocation?

I combined the invocation.

myguidingstar · 2018-11-01T10:53:48Z

@clefru I got this error when trying to launch emulator:

[140623058774912]:ERROR:android/android-emu/android/qt/qt_setup.cpp:28:Qt library not found at /nix/store/ks3zbnxm0kaq1js6cdzxi1ji3q52h6r7-android-sdk-26.1.1/emulator/lib64/qt/lib
Could not launch '/nix/store/ks3zbnxm0kaq1js6cdzxi1ji3q52h6r7-android-sdk-26.1.1/emulator/qemu/linux-x86_64/qemu-system-x86_64': No such file or directory

clefru · 2018-11-01T13:27:50Z

@clefru I got this error when trying to launch emulator:

[140623058774912]:ERROR:android/android-emu/android/qt/qt_setup.cpp:28:Qt library not found at /nix/store/ks3zbnxm0kaq1js6cdzxi1ji3q52h6r7-android-sdk-26.1.1/emulator/lib64/qt/lib
Could not launch '/nix/store/ks3zbnxm0kaq1js6cdzxi1ji3q52h6r7-android-sdk-26.1.1/emulator/qemu/linux-x86_64/qemu-system-x86_64': No such file or directory

I am aware of that. Looks like the qemu binaries were removed, and moved into a downloadable artefact, see https://developer.android.com/studio/releases/emulator

I don't understand how to access the artifact, and this needs to be addressed in a separate commit. This PR is solely reverting a change in 950608b#diff-8732e6195b98297321a5343f293624cfL68

clefru · 2018-11-01T14:23:43Z

I found a way to re-add the emulator. It's a bit crude. Please test.

You can only invoke the emulator by the fully wrapped entry points under libexec/tools/*. The binaries under libexec/emulator/ are only patched for their interpreter. rpath's aren't fixed as this will be inherited from the LD_LIBRARY_PATH wrap when call from libexec/tools/emulator.

myguidingstar · 2018-11-01T17:43:48Z

just tested. The error remains:

[140160916286336]:ERROR:android/android-emu/android/qt/qt_setup.cpp:28:Qt library not found at /nix/store/7a5q5cqk39zc031pan4ld9993bw9qanf-android-sdk-26.1.1/emulator/lib64/qt/lib
Could not launch '/nix/store/7a5q5cqk39zc031pan4ld9993bw9qanf-android-sdk-26.1.1/emulator/qemu/linux-x86_64/qemu-system-x86_64': No such file or directory

…age.

clefru · 2018-11-02T09:15:50Z

Updated PR to wrap/patch all emulator binaries. Please retest. This probably needlessly patches/wraps a few binaries.

myguidingstar · 2018-11-02T17:23:27Z

the qt error is still there :(

clefru · 2018-11-03T08:50:44Z

Ah, the problem seems to be not including emulator/lib64/qt/lib into the LD_LIBRARY_PATH. Well, this is getting tedious. I am not going to manually figure out which binary needs which.

I suggest that we plainly revert 950608b#diff-8732e6195b98297321a5343f293624cfL68 and then work on a plan to merge https://discourse.nixos.org/t/my-revised-experimental-android-build-functions/923

This is a dead-end here.

myguidingstar · 2018-11-03T08:56:08Z

@clefru can you give me some instruction on how to make use of Sander's nix-androidenvtests above. How do I put things together and what does a basic .nix to feed to nix-build look like?

clefru · 2018-11-03T09:02:21Z

I replied to you on the discourse thread. Best option might be to stick to the 18.09 release, which should still have a working emulator.

corngood · 2018-11-10T19:27:54Z

@clefru I took your change made a small fixup: corngood@d3c3221

It's just ignoring tools/emulator and linking to emulator/emulator instead.

The emulator starts up fine for me now, but I haven't tested it a whole lot.

Mic92 · 2018-11-10T22:18:56Z

@corngood can you open a pull request?

corngood · 2018-11-11T00:43:41Z

@Mic92 I can, but I think it might still need a bit more work. There's this error when starting the emulator:

ERROR: resizing partition failed to launch /nix/store/gw8sj81sp6wyby2xqa64jyw7z8b492nh-android-sdk-26.1.1/libexec/emulator/bin64/e2fsck

Which is probably just more missing elf patches.

Also the SDK reports that the emulator is out of date.

This reverts commit 950608b. This broke the emulator: NixOS#49515 (comment)

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 31, 2018

Mic92 reviewed Oct 31, 2018

View reviewed changes

nicknovitski mentioned this pull request Nov 1, 2018

androidenv.androidsdk: patch x64 interpreter path of emulator{,-check} #49564

Closed

7 tasks

Mic92 mentioned this pull request Nov 1, 2018

Update android sdk, add license config option and selectable build tools #48848

Merged

9 tasks

clefru force-pushed the android-emulator-fix branch 2 times, most recently from 36a57a3 to 54779e9 Compare November 1, 2018 14:21

clefru changed the title ~~androidsdk: emulator(-check) binaries still require patchElf.~~ androidsdk: Re-add emulator Nov 1, 2018

androidsdk: Re-add emulator that was broken out of the sdk-tools pack…

0d6d19e

…age.

clefru force-pushed the android-emulator-fix branch from 54779e9 to 0d6d19e Compare November 2, 2018 09:12

clefru closed this Nov 3, 2018

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Nov 12, 2018

Revert "androidsdk: 25.2.5 -> 26.1.1, license agreement"

5f2c133

This reverts commit 950608b. This broke the emulator: NixOS#49515 (comment)

Mic92 mentioned this pull request Nov 12, 2018

Revert "androidsdk: 25.2.5 -> 26.1.1, license agreement" #50263

Closed

corngood mentioned this pull request Nov 12, 2018

androidsdk: fix emulator #50276

Merged

9 tasks

Uh oh!

Conversation

clefru commented Oct 31, 2018

Motivation for this change

Things done

Uh oh!

Mic92 Oct 31, 2018

Choose a reason for hiding this comment

Uh oh!

Mic92 Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clefru Nov 1, 2018

Choose a reason for hiding this comment

Uh oh!

myguidingstar commented Nov 1, 2018

Uh oh!

clefru commented Nov 1, 2018

Uh oh!

clefru commented Nov 1, 2018

Uh oh!

myguidingstar commented Nov 1, 2018

Uh oh!

clefru commented Nov 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myguidingstar commented Nov 2, 2018

Uh oh!

clefru commented Nov 3, 2018

Uh oh!

myguidingstar commented Nov 3, 2018

Uh oh!

clefru commented Nov 3, 2018

Uh oh!

corngood commented Nov 10, 2018

Uh oh!

Mic92 commented Nov 10, 2018

Uh oh!

corngood commented Nov 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Mic92 Nov 1, 2018 •

edited

Loading

clefru commented Nov 2, 2018 •

edited

Loading